Add IsComplexTextEdit property to CompletionItem #51470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonchou
requested review from
genlu,
NTaylorMullen,
CyrusNajmabadi and
dibarbet
NTaylorMullen
approved these changes
Feb 25, 2021
src/Features/LanguageServer/Protocol/Handler/Completion/CompletionHandler.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Mar 2, 2021
CyrusNajmabadi
approved these changes
Mar 2, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51166 added support for override and partial method completions in LSP. However, the current approach involves looking up information via an individual completion item's property bag to see whether the completion item is an override or partial method completion. This is an incorrect approach since we should not be using the property bags to determine this information.
As a more proper solution, this PR adds a new property to the CompletionItem class named
IsComplexTextEdit, which completion providers may returntruefor if a given completion item requires complex resolution and will potentially impact performance.Resolves #51396.